Adding test to test Ephemerons in the Old Space #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jordanmontt , is this finally an issue or not? |
This reverts commit 7714363.
guillep
requested changes
Aug 28, 2024
There was a problem hiding this comment.
I don't think we should integrate it as it is. Besides the structural silly change of moving the tests to the right classes, there is at least one test that contradicts another tests that already exist. So one of them is wrong, we cannot keep both.
Also, adding broken tests to the suite is not good. They should come with the proper fix...
smalltalksrc/VMMakerTests/VMSpurEphemeronsAlgorithmTest.class.st
Outdated
Show resolved
Hide resolved
smalltalksrc/VMMakerTests/VMSpurEphemeronsAlgorithmTest.class.st
Outdated
Show resolved
Hide resolved
smalltalksrc/VMMakerTests/VMSpurEphemeronsAlgorithmTest.class.st
Outdated
Show resolved
Hide resolved
|
Thanks for the feedback! I will move the useful tests to the default test class and close this PR |
…merons in the old space.
|
Mmmm the new tonel format :/ *$%$#@#$ |
…the ephemerons in the old space." This reverts commit 210b40d.
jordanmontt
changed the title
jordanmontt
changed the title
|
It looks like it's ready to be integrated @guillep . Failing tests Tests-Linux-x86_64-CoInterpreter Tests-Linux-x86_64-CoInterpreter-worker don't seem related |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a class that tests some edge cases of the finalization algorithm. The class has failing tests which is good. That means that we found some errors on the finalization algorithm. Next step is to fix those errors